fix(schema): avoid deadlock on reload_schema error #480
+70
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakhov
force-pushed
the
fix/schema-reload-deadlock-after-error
branch
from
bbc93d6 to
955c1ee
Compare
p0rtale
reviewed
Jan 26, 2026
p0rtale
approved these changes
Jan 26, 2026
Satbek
reviewed
Feb 3, 2026
vakhov
force-pushed
the
fix/schema-reload-deadlock-after-error
branch
3 times, most recently
from
9efdd24 to
7d9b13e
Compare
vakhov
force-pushed
the
fix/schema-reload-deadlock-after-error
branch
from
7d9b13e to
642354d
Compare
Satbek
approved these changes
Feb 3, 2026
vakhov
force-pushed
the
fix/schema-reload-deadlock-after-error
branch
from
642354d to
2f55d98
Compare
Ensure reload_schema always clears reload_in_progress flag and broadcasts condition variable even if schema reload fails or times out. Previously, an early return on error left reload_in_progress set to true, causing subsequent crud.schema() calls to wait until timeout indefinitely. Add integration test reproducing the issue and verifying that schema reload can be retried successfully after a failure. Fixes #479
vakhov
force-pushed
the
fix/schema-reload-deadlock-after-error
branch
from
2f55d98 to
4d60fe2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure reload_schema always clears reload_in_progress flag and broadcasts condition variable even if schema reload fails or times out.
Previously, an early return on error left reload_in_progress set to true, causing subsequent crud.schema() calls to wait until timeout indefinitely.
Fixes #479