Skip to content

Conversation

@p7nov
Copy link
Contributor

@p7nov p7nov commented Oct 29, 2024

Resolves #4612

Deployment: https://docs.d.tarantool.io/en/doc/gh-4612-initial-settings/tooling/tcm/tcm_configuration/

@p7nov p7nov requested a review from vaintrub October 30, 2024 09:30
@p7nov p7nov requested a review from xuniq October 31, 2024 09:23
Copy link
Contributor

@xuniq xuniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment.

Comment on lines 2483 to 2495
The maximum size (in bytes) of a message between the cluster and its etcd
configuration storage. TODO:check

|
| Type: int
| Default: TODO?? 2097152?
.. _tcm_configuration_reference_initial_cluster_storage_etcd_maxcallrecv:

.. confval:: initial-settings.clusters.<cluster>.storage-connection.etcd-connection.max-call-recv-msg-size

The maximum size (in bytes) of a message between the cluster and its etcd
configuration storage. TBD:check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The texts are identical for these options, is that okay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm awaiting details to update these, thanks for spotting.

@p7nov p7nov merged commit b4ac572 into latest Nov 6, 2024
1 check passed
@p7nov p7nov deleted the gh-4612-initial-settings branch November 6, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TCM] Initial settings

4 participants