Add migrations troubleshoot warning #4629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p7nov
reviewed
Nov 12, 2024
Contributor
p7nov
left a comment
p7nov
left a comment
There was a problem hiding this comment.
Please check my suggestions
Comment on lines
52
to
53
| Any schema change that was made by incorrect migration before the fail or | ||
| cancellation must be resolved manually on each replicaset before reapply. |
Contributor
There was a problem hiding this comment.
Suggested change
| Any schema change that was made by incorrect migration before the fail or | |
| cancellation must be resolved manually on each replicaset before reapply. | |
| Any schema change that was made by an incorrect migration before its fail or | |
| cancellation must be resolved manually on each replica set before reapply. |
Comment on lines
54
to
55
| Apply flags like ``--force-reapply`` affect only internal migration status and | ||
| unable to revert migration scenario itself. |
Contributor
There was a problem hiding this comment.
Suggested change
| Apply flags like ``--force-reapply`` affect only internal migration status and | |
| unable to revert migration scenario itself. | |
| ``--force-reapply`` and other ``tt migrations`` options affect only internal status of the migration | |
| and don't revert changes that it has made in the cluster. |
DifferentialOrange
force-pushed
the
DifferentialOrange/no-gh-migrations-apply-warn
branch
from
bd9e7b6 to
ef162ce
Compare
p7nov
approved these changes
Nov 12, 2024
Contributor
p7nov
left a comment
p7nov
left a comment
There was a problem hiding this comment.
Great, thanks for the addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users expect that
--force-reapplyor--overwritewill revert the partial result of incorrect migration, yet it is impossible. This patch adds a warning regarding this expectation.