Updates default value for replication_sync_timeout #5186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecl1s
suggested changes
Jun 18, 2025
|
|
||
| The default ``replication_sync_timeout`` value is going to be changed in future versions from ``300`` to ``0``. | ||
| You can learn the reasoning behind this decision from the :ref:`Default value for replication_sync_timeout <compat-option-replication-timeout>` topic, which also describes how to try the new behavior in the current version. | ||
| The default ``replication_sync_timeout`` value can be changed to 300 by using the ``compat`` module. |
There was a problem hiding this comment.
It creates the erroneous impression that only two values are possible: 0 and 300. This is not the case. I think it would be better to avoid "300" and replace it with "old value" or similar. The link provided to compat option will reveal the necessary details.
Contributor
Author
There was a problem hiding this comment.
Updated, thank you!
xuniq
approved these changes
Jun 19, 2025
tecl1s
approved these changes
Jun 19, 2025
Changes default value in the description from 300 to 0 Fixes #5183
AArdeev
force-pushed
the
AArdeev/gh-5183-fix-default-timeout-value
branch
from
dc37181 to
4ca4ddc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Fix default value in
replication_sync_timeout#5183Deployment: