Added logic for working with Tarantool schema via Box#426
Added logic for working with Tarantool schema via Box#426KaymeKaydex wants to merge 1 commit intotarantool:masterfrom
Conversation
2e271da to
9f736f4
Compare
07de408 to
0a3720b
Compare
0a3720b to
3155a23
Compare
There was a problem hiding this comment.
Please, add more unit-tests for a new requests/response. You could see how it is tested on the main package and inside the crud subpackage.
We also need examples (in example_test.go) with new features. This will help users to use the library.
Finally, we need to keep a backward compatibility until a next major release, so we need to add another Info() method with a context instead of changing the current one.
5c9bb77 to
1e3625c
Compare
i removed interface changes |
1e3625c to
75e1930
Compare
40555ec to
4954fc7
Compare
3695443 to
5d690db
Compare
Implemented the `box.Schema()` method that returns a `Schema` object for schema-related operations
There was a problem hiding this comment.
Thanks for the patch. It would be nice if @dmyger paid attention to the test per function coverage.
As I could see the code is not covered (and some MessagePack unmarshal errors, but it is not critical):

Please, add a test for it.
| // Schema returns a new Schema instance, providing access to schema-related operations. | ||
| // It uses the connection from the Box instance to communicate with Tarantool. | ||
| func (b *Box) Schema() *Schema { | ||
| return NewSchema(b.conn) | ||
| } |
There was a problem hiding this comment.
It would be nice to write a unit-test that checks whether the created circuit uses the connection passed to box.New.
oleg-jukovec
left a comment
There was a problem hiding this comment.
See comments above.
|
Thank you for the PR! We've added some minor fixes and merged it: #446 |
box.Schema()method that returns aSchemaobject for schema-related operationsWhat has been done? Why? What problem is being solved?
I didn't forget about (remove if it is not applicable):
Related issues: