Extend box information with replication fields

[w33dw0r7d]

What has been done? Why? What problem is being solved?

Extend box information with replication fields.

I didn't forget about (remove if it is not applicable):

• Changelog (see documentation for changelog format)

[oleg-jukovec]

Thank you for the patch!

Please, add tests for the change (integration tests to the box/tarantool_test.go and a unit-tests of the message pack decoding in info_test.go).

[w33dw0r7d]

@oleg-jukovec Thanks for the quick response.
I add integration test and add pull request number in changelog.

unit-tests of the message pack decoding in info_test.go

Please tell me what you think needs to be tested in this test.

[oleg-jukovec]

Please tell me what you think needs to be tested in this test.

You could encode a map as a MessagePack and decode it as InfoResponse. The pseudo-code:

expected := InfoResponse{
     Info: Info{
         Foo: "bar",
     },
}
data, err := msgpack.Marshal(map[string]any{
     "foo": "bar",
})
require.NoError(err)

var result InfoResponse
err = msgpack.Unmarshal(data, &result)
require.NoError(err)

require.Equals(t, expected, result)

In that way you could ensure that all fields decoded as expected and you don't make a mistake or misprint. It also would be a good starting point for tests in the future.

You need to cover decoding of all new fields with the test.

[w33dw0r7d]

@oleg-jukovec Thanks for your detailed answer. I add tests. Could you please take a look?

[w33dw0r7d]

Add additional fields .message .system_message.

[oleg-jukovec]

Please, fix linter errors:

  Error: box/info_test.go:63:1: The line is 106 characters long, which exceeds the maximum of 100 characters. (lll)
  							Message:       "'getaddrinfo: Name or service not known: Input/output error'",
  ^
  Error: box/info_test.go:100:1: The line is 109 characters long, which exceeds the maximum of 100 characters. (lll)
  							"message":        "'getaddrinfo: Name or service not known: Input/output error'",
  ^
  
  Error: issues found

[w33dw0r7d]

@oleg-jukovec For some unknown reason local golangci-lint doesn't work. Fix all problems.

[oleg-jukovec]

Thank you for the patch!

[DerekBum]

Thanks for the patch, just some small nits.

[w33dw0r7d]

@DerekBum Thanks for you review.

[oleg-jukovec]

Thank you for the patch!