feat(arrow, datetime, decimal, uuid): add support for go-option #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for `go-option` to the `arrow`, `datetime`, `decimal`, and `uuid` packages. This allows for handling optional values of the `Arrow`, `Datetime`, `Interval`, `Decimal`, and `UUID` types. The following changes have been made: - Added `go:generate` directives to the `Arrow`, `Datetime`, `Interval`, `Decimal`, and `UUID` types to generate optional types using `github.com/tarantool/go-option/cmd/gentypes`. - Implemented `MarshalMsgpack` and `UnmarshalMsgpack` methods for the `Arrow`, `Datetime`, `Interval`, and `Decimal` types. - Added `marshalUUID` and `unmarshalUUID` functions for the `UUID` type. - The generated `_gen.go` files contain the `Optional*` types that wrap the original types and provide methods to handle optional values, including `EncodeMsgpack` and `DecodeMsgpack` for `msgpack` serialization. - Refactored the `datetime` and `decimal` decoders to use the new `UnmarshalMsgpack` methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
go-optionto thearrow,datetime,decimal, anduuidpackages. This allows for handling optional values of theArrow,Datetime,Interval,Decimal, andUUIDtypes.The following changes have been made:
go:generatedirectives to theArrow,Datetime,Interval,Decimal, andUUIDtypes to generate optional types usinggithub.com/tarantool/go-option/cmd/gentypes.MarshalMsgpackandUnmarshalMsgpackmethods for theArrow,Datetime,Interval, andDecimaltypes.marshalUUIDandunmarshalUUIDfunctions for theUUIDtype._gen.gofiles contain theOptional*types that wrap the original types and provide methods to handle optional values, includingEncodeMsgpackandDecodeMsgpackformsgpackserialization.datetimeanddecimaldecoders to use the newUnmarshalMsgpackmethods.Closes #TNTP-3735.