api: updated response/future methods by ermyar · Pull Request #501 · tarantool/go-tarantool

ermyar · 2025-11-24T08:01:54Z

Added method Release to Future and Response's interface, that allows to free used data directly by calling. Used to reduce allocations in creating and using slices of bytes and buffers. Concretely, reducing allocs in read part and buffer allocation of reader function.

Fixes #493

I didn't forget about (remove if it is not applicable):

Tests (see documentation for a testing package)
Changelog (see documentation for changelog format)

oleg-jukovec

Thank you for the patch!

See issues of the current implementation, fix them and we will try again.

response.go

future.go

connection.go

tarantool_test.go

response.go

dial.go

test_helpers/response.go

connection.go

bigbes · 2026-01-21T01:03:42Z

Actualize PR/commit title/description.
Right now "api: updated response/future methods" isn't very descriptive and i'm not sure, that "Connection now contains sync.Pool that was used to reduce allocations." isn't correct, as I've understand.

oleg-jukovec · 2026-02-17T14:01:51Z

test_helpers/response.go

 }

+func (resp *MockResponse) Release() {
+	// Releasing MockResponse data.


Suggested change

// Releasing MockResponse data.

// Nothing to do.

oleg-jukovec · 2026-02-17T14:04:32Z

tarantool_test.go

+	var err error
+
+	conn := test_helpers.ConnectWithValidation(b, dialer, opts)
+	defer conn.Close()
+
+	_, err = conn.Do(
+		NewReplaceRequest(spaceNo).
+			Tuple([]interface{}{uint(1111), "hello", "world"}),
+	).Get()


This makes the test a bit shorter.

Suggested change

var err error

conn := test_helpers.ConnectWithValidation(b, dialer, opts)

defer conn.Close()

_, err = conn.Do(

NewReplaceRequest(spaceNo).

Tuple([]interface{}{uint(1111), "hello", "world"}),

).Get()

conn := test_helpers.ConnectWithValidation(b, dialer, opts)

defer conn.Close()

_, err := conn.Do(

NewReplaceRequest(spaceNo).

Tuple([]interface{}{uint(1111), "hello", "world"}),

).Get()

oleg-jukovec · 2026-02-17T15:05:03Z

connection.go

-		buf := smallBuf{b: respBytes}
-		header, code, err := decodeHeader(conn.dec, &buf)
+
+		buf.tinyBuf = *respBytes


It seems like a separate structure for the buffer is unnecessary, since we're essentially interested in a slice here.

Especially since the tinybuf is passed by value anyway, and the original pointer is lost anyway.

So I've propose do not create a separate structure for the purpose since it makes no sense. We already can use slices.

Suggested change

buf.tinyBuf = *respBytes

buf.b = respBytes

oleg-jukovec · 2026-02-17T15:10:04Z

response.go

+}
+
+func (resp *baseResponse) Release() {
+	slicePool.Put(&resp.buf.tinyBuf)


We need to release the resource only if the buffer is actually allocated by ourselves in the branch:

go-tarantool/response.go

Lines 44 to 46 in 90195f7

resp.header = header

resp.buf.b = buf.b

resp.buf.p = buf.p

So we need some flag in the baseResponse structure.

Suggested change

slicePool.Put(&resp.buf.tinyBuf)

if resp.allocated {

slicePool.Put(&resp.buf.tinyBuf)

}

oleg-jukovec · 2026-02-17T15:14:52Z

response.go

+var selectResponsePool *sync.Pool = &sync.Pool{
+	New: func() interface{} {
+		return &SelectResponse{}
+	},
+}
+
+func createSelectResponse(header Header, body io.Reader) (*SelectResponse, error) {
+	resp := selectResponsePool.Get().(*SelectResponse)
+	if body == nil {
+		resp.header = header
+		return resp, nil
+	}
+	if buf, ok := body.(*smallBuf); ok {
+		resp.header = header
+		resp.buf.b = buf.b
+		resp.buf.p = buf.p
+		return resp, nil
+	}
+	data, err := io.ReadAll(body)
+	if err != nil {
+		return resp, err
+	}
+	resp.header = header
+	resp.buf.b = data
+	return resp, nil
+}
+
+func (resp *SelectResponse) Release() {
+	resp.baseResponse.Release()
+	resp.baseResponse = baseResponse{}
+	resp.pos = nil
+
+	selectResponsePool.Put(resp)
+}


Nice, but let split the PR into two parts:

With the reader() buffers optimization.

With the requests optimization (the selected part).

It would be much easier to merge it one by one.

oleg-jukovec · 2026-02-17T15:16:15Z

Please, rebase & update the PR.

oleg-jukovec · 2026-02-17T16:14:56Z

https://github.com/grpc/grpc-go/blob/master/mem/buffer_pool.go

oleg-jukovec · 2026-02-17T16:15:04Z

https://github.com/grpc/grpc-go/blob/master/mem/buffer_pool.go#L267C2-L267C35

Added method Release to Future and Response's interface, that allows to free used data directly by calling. Used to reduce allocations in `reader` function. Closes #493

ermyar requested a review from oleg-jukovec November 24, 2025 11:20

ermyar force-pushed the ermyar/gh-493-reduce-reader-allocations branch from 1f3999a to e37fa1b Compare November 25, 2025 15:56

ermyar marked this pull request as ready for review November 25, 2025 16:25

ermyar force-pushed the ermyar/gh-493-reduce-reader-allocations branch from e37fa1b to bf0bbdc Compare November 25, 2025 16:31

ermyar requested a review from bigbes November 28, 2025 10:08

oleg-jukovec requested changes Dec 1, 2025

View reviewed changes

ermyar force-pushed the ermyar/gh-493-reduce-reader-allocations branch 2 times, most recently from a15281c to 078cb7d Compare December 1, 2025 22:56

ermyar requested a review from oleg-jukovec December 1, 2025 23:26

ermyar force-pushed the ermyar/gh-493-reduce-reader-allocations branch 2 times, most recently from beda545 to 50c8953 Compare December 2, 2025 01:50

bigbes reviewed Dec 5, 2025

View reviewed changes

connection.go Outdated Show resolved Hide resolved

ermyar force-pushed the ermyar/gh-493-reduce-reader-allocations branch from 50c8953 to 553c00f Compare December 5, 2025 14:20

ermyar requested a review from bigbes December 8, 2025 19:07

ermyar force-pushed the ermyar/gh-493-reduce-reader-allocations branch from 553c00f to 3540852 Compare December 19, 2025 13:28

oleg-jukovec requested changes Jan 20, 2026

View reviewed changes

ermyar force-pushed the ermyar/gh-493-reduce-reader-allocations branch from 3540852 to 90195f7 Compare February 10, 2026 15:37

oleg-jukovec requested changes Feb 17, 2026

View reviewed changes

ermyar force-pushed the ermyar/gh-493-reduce-reader-allocations branch from 90195f7 to 783a2c9 Compare February 24, 2026 06:27

api: added future/response releasing methods

b2dbe37

Added method Release to Future and Response's interface, that allows to free used data directly by calling. Used to reduce allocations in `reader` function. Closes #493

ermyar force-pushed the ermyar/gh-493-reduce-reader-allocations branch from 783a2c9 to b2dbe37 Compare February 24, 2026 06:40

ermyar requested a review from oleg-jukovec February 24, 2026 06:50

Conversation

ermyar commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oleg-jukovec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bigbes commented Jan 21, 2026

Uh oh!

oleg-jukovec Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

oleg-jukovec Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

oleg-jukovec Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

oleg-jukovec Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

oleg-jukovec Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

oleg-jukovec commented Feb 17, 2026

Uh oh!

oleg-jukovec commented Feb 17, 2026

Uh oh!

oleg-jukovec commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ermyar commented Nov 24, 2025 •

edited

Loading