Open
Conversation
Base automatically changed from
ermyar/gh-493-reduce-reader-allocations
to
master
March 5, 2026 12:59
Collaborator
|
Please, rebase the PR. |
ermyar
force-pushed
the
ermyar/gh-493-reduce-read-allocations
branch
from
e61434b to
05bb9da
Compare
oleg-jukovec
requested changes
Mar 5, 2026
Collaborator
oleg-jukovec
left a comment
oleg-jukovec
left a comment
There was a problem hiding this comment.
Thanks for the patch!
Except for the comments, everything is fine here. But let's improve the solution a bit here before merge.
Let's use the approach from the grpc-go:
https://github.com/grpc/grpc-go/blob/master/mem/buffer_pool.go
Create multiple buffers with constant byte sizes instead of the single one. Response that does not fit into these buffers should be allocated separately without a pool and without a release.
It shouldn't be copy-paste, but inspirated the go-grpc's code.
Another option is that you can correct the current comments and we will merge the PR, and you will implement logic with buffer pools in another one.
response.go
Outdated
Comment on lines
+690
to
+710
| func createSelectResponse(header Header, body io.Reader) (*SelectResponse, error) { | ||
| resp := &SelectResponse{} | ||
| if body == nil { | ||
| resp.header = header | ||
| return resp, nil | ||
| } | ||
| if buf, ok := body.(*smallBuf); ok { | ||
| resp.header = header | ||
| resp.buf.b = buf.b | ||
| resp.buf.p = buf.p | ||
| resp.buf.ptr = buf.ptr | ||
| return resp, nil | ||
| } | ||
| data, err := io.ReadAll(body) | ||
| if err != nil { | ||
| return resp, err | ||
| } | ||
| resp.header = header | ||
| resp.buf.b = data | ||
| return resp, nil | ||
| } |
ermyar
force-pushed
the
ermyar/gh-493-reduce-read-allocations
branch
5 times, most recently
from
0bfee57 to
0d3cbe1
Compare
bigbes
reviewed
Mar 12, 2026
|
|
||
| // getInd returns least index of size slice, | ||
| // which is great or equal given size. | ||
| func (p *pooler) getInd(size int) int { |
bigbes
reviewed
Mar 12, 2026
slice_pool.go
Outdated
| } | ||
|
|
||
| // getInd returns least index of size slice, | ||
| // which is great or equal given size. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // which is great or equal given size. | |
| // which is greater or equal given size. |
bigbes
reviewed
Mar 12, 2026
slice_pool.go
Outdated
| } | ||
|
|
||
| // getSlice returns pointer of byte slice of given size, | ||
| // also clear returning array. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // also clear returning array. | |
| // also clear returning slice. |
Added method Release to Future and Response's interface, that allows to free used data directly by calling. Used to reduce allocations in `reader` function. Closes #493
ermyar
force-pushed
the
ermyar/gh-493-reduce-read-allocations
branch
from
0d3cbe1 to
322ad09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added method Release to Future and Response's interface, that allows to free used data directly by calling. Used to reduce allocations in
readerfunction. Concretely, reducing alloc's in read part.Fixes #493