internal: fix smallBuf allocation in the reader#546
Merged
oleg-jukovec merged 1 commit intomasterfrom Mar 18, 2026
Merged
Conversation
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-no-local-smallbuf
branch
from
bf8cdb5 to
d841832
Compare
oleg-jukovec
changed the title
Move `smallBuf` variable declaration outside the reader loop to reduce memory allocations per request. Benchmark results (BenchmarkSync_naive_with_custom_type_with_Release): - master: 4 allocs/op, 321 B/op - this fix: 3 allocs/op, 288 B/op Add examples demonstrating custom Request implementation with the Response method. The examples show that custom requests must read all response data immediately since the io.Reader is only valid during the call.
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-no-local-smallbuf
branch
from
d841832 to
635572c
Compare
patapenka-alexey
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
smallBufvariable declaration outside the reader loop to reduce memory allocations per request.Benchmark results (BenchmarkSync_naive_with_custom_type_with_Release):
Add examples demonstrating custom Request implementation with the Response method. The examples show that custom requests must read all response data immediately since the io.Reader is only valid during the call.