-
Notifications
You must be signed in to change notification settings - Fork 14
dashboard: cpu/memory/virtual memory panels #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
dashboard: cpu/memory/virtual memory panels #245
Conversation
ce8eeda to
7a9bc4f
Compare
7a9bc4f to
d1b1905
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, squash commits.
| #RUN DEBIAN_FRONTEND=noninteractive apt install -y git patch | ||
| #RUN git clone https://github.com/magefile/mage && \ | ||
| # cd mage && \ | ||
| # go run bootstrap.go | ||
| #RUN tt install tt master | ||
| #RUN tt install tarantool master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, revert the changes or fix the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's temporarily debug stuff.
|
Is it possible to sum system and user time for cpu graphs by thread? |
fd41f66 to
4bfde95
Compare
Yes, all required metrics are provided by |
4bfde95 to
bc4b63e
Compare
bc4b63e to
d1d8047
Compare
c883af2 to
c7a8a72
Compare
dashboard/panels/runtime.libsonnet
Outdated
| title='Total memory per instance', | ||
| description=||| | ||
| Total memory used by Tarantool. | ||
| |||, | ||
| ):: common.default_graph( | ||
| cfg, | ||
| title=title, | ||
| description=description, | ||
| format='bytes', | ||
| labelY1='in bytes', | ||
| panel_width=8, | ||
| ).addTarget( | ||
| if cfg.type == variable.datasource_type.prometheus then | ||
| prometheus.target( | ||
| expr=std.format( | ||
| ||| | ||
| (%(metrics_prefix)stnt_memory{%(filters)s}) + | ||
| (%(metrics_prefix)stnt_memory_virt{%(filters)s}) | ||
| |||, | ||
| { | ||
| metrics_prefix: cfg.metrics_prefix, | ||
| filters: common.prometheus_query_filters(common.remove_field(cfg.filters, 'alias')), | ||
| } | ||
| ), | ||
| legendFormat=title, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If per instance, then
| title='Total memory per instance', | |
| description=||| | |
| Total memory used by Tarantool. | |
| |||, | |
| ):: common.default_graph( | |
| cfg, | |
| title=title, | |
| description=description, | |
| format='bytes', | |
| labelY1='in bytes', | |
| panel_width=8, | |
| ).addTarget( | |
| if cfg.type == variable.datasource_type.prometheus then | |
| prometheus.target( | |
| expr=std.format( | |
| ||| | |
| (%(metrics_prefix)stnt_memory{%(filters)s}) + | |
| (%(metrics_prefix)stnt_memory_virt{%(filters)s}) | |
| |||, | |
| { | |
| metrics_prefix: cfg.metrics_prefix, | |
| filters: common.prometheus_query_filters(common.remove_field(cfg.filters, 'alias')), | |
| } | |
| ), | |
| legendFormat=title, | |
| title='Total memory per instance', | |
| description=||| | |
| Total memory used by Tarantool. | |
| |||, | |
| ):: common.default_graph( | |
| cfg, | |
| title=title, | |
| description=description, | |
| format='bytes', | |
| labelY1='in bytes', | |
| panel_width=8, | |
| ).addTarget( | |
| if cfg.type == variable.datasource_type.prometheus then | |
| prometheus.target( | |
| expr=std.format( | |
| ||| | |
| (%(metrics_prefix)stnt_memory{%(filters)s}) + | |
| (%(metrics_prefix)stnt_memory_virt{%(filters)s}) | |
| |||, | |
| { | |
| metrics_prefix: cfg.metrics_prefix, | |
| filters: common.prometheus_query_filters(), | |
| } | |
| ), | |
| legendFormat='{{alias}}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, tnx!
| cfg, | ||
| title='Total memory per instance', | ||
| description=||| | ||
| Total memory used by Tarantool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try to add such comments for new panels in case one would wonder "Why the panel is empty for my application"
| Total memory used by Tarantool. | |
| Total memory used by Tarantool. | |
| Panel minimal requirements: metrics 1.6.0. |
dashboard/panels/runtime.libsonnet
Outdated
| measurement: cfg.measurement, | ||
| }), | ||
| metric_memory: cfg.metrics_prefix + 'tnt_memory', | ||
| filters: common.influxdb_query_filters(cfg.filters), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove alias here as well for "per cluster"
dashboard/panels/runtime.libsonnet
Outdated
| measurement: cfg.measurement, | ||
| }), | ||
| metric_memory_virt: cfg.metrics_prefix + 'tnt_memory_virt', | ||
| filters: common.influxdb_query_filters(cfg.filters), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove alias here as well for "per cluster"
This patch adds `CPU/memory/virtual memory` utilization panels per instance and total. Closes #TNTP-4365
c7a8a72 to
76d15fe
Compare
This patch adds
CPU/memory/virtual memoryutilization panels per instance and total.Closes #TNTP-4365
screenshots