Conversation
DifferentialOrange
left a comment
There was a problem hiding this comment.
I don't quite get why I was summoned to review luatest PR since I never contributed here and don't know how the infrastructure works, but the patch seems fine.
You can also think about unifying the code with assert_covers since they do similar things.
32b673f to
176ac51
Compare
|
AFAIK we generaly follow the LuaUnit assertion naming (but just snake case variants). There are |
For me, |
|
BTW, the implementation is not exactly same. You're using Regarding However, I still think that LuaUnit names are good enough and I see no reason to use different ones. |
|
As for me |
Add
assert_one_ofto assert that the value is one of several alternatives.It could be useful to write tests that support several tarantool versions.