Fixes pack #146
Merged
Fixes pack #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brain5lug
commented
Sep 30, 2025
brain5lug
commented
- make logger a bit faster
- std::forward related fixes
- use std::string_view for call function
drewdzzz
approved these changes
Oct 10, 2025
|
@CuriousGeorgiy I've checked linter complaints - they don't relate to the actual code changes, so I suggest to ignore it. The only actual complaints are about writing all the move constructors from the second commit in one line - that's what my nitpick suggests. |
brain5lug
force-pushed
the
brain5lug/fixes-pack
branch
from
0401fe1 to
320af2d
Compare
Eliminate copying from std::stringstream if complied with C++20 or higher
std::forward were replace std::move for fixed type context where it does not make sense. Some redundant comment were removed as they declare obvious actions under them.
For most of cases encoding fuction such as `call`, `execute` and `prepare` use predefined fixed literal. Those values are best to be expressed as std::string_view literals. std::string_view are really usefull and can be easily createad from any sequense memory areas. There are no changes are required from cliend side as std::string_view can be implicilty coverted from std::string.
brain5lug
force-pushed
the
brain5lug/fixes-pack
branch
from
320af2d to
4fecfc2
Compare
CuriousGeorgiy
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
@brain5lug
Thanks for the patches and your fixes, all neat and shiny! Happy to see you around and chat about tntcxx code and design if you have any more ideas for improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.