Extended warnings #88
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old decoder is no longer suuported - let's remove it. There is 0.1.0 version of tntcxx for ones who want to use it.
drewdzzz
force-pushed
the
extended_warnings
branch
8 times, most recently
from
26ea20b to
b8449c2
Compare
Some compound assignments called on non-standard trivial types (e.g, short int) were split into operators and assignments because of strange gcc behavior (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56908).
drewdzzz
force-pushed
the
extended_warnings
branch
2 times, most recently
from
f20152f to
144954c
Compare
Since libev and sha1 do not suite very strict GCC shadowing rules, the commit does not enable shadowing warning for these third-party libraries.
drewdzzz
force-pushed
the
extended_warnings
branch
from
144954c to
979de54
Compare
Our codebase already suits these rules - we need only to enable them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.