Open
Conversation
Contributor
|
DST offset, this really emphasizes how important it is to be able to test this - cause in my experience (when this was more of a CLI than an Action, I had off-by-one errors the other way). it felt related to DST and I'd like to look more closely into this, but have low capacity and this also emphasizes how hard it is to test and iterate on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14
Fixes #5 - Custom information, like a Slack channel, can be provided via the template.
I'll admit... this is a pretty substantial PR. But it gets the action ready for use by the
nodejs/web-team, especially since there’s still no ETA on Node.js’s own generator.This PR includes:
Templating support, allowing us to specify invitees for
nodejs/web-team.Removal of DST offset handling: