feat(rate-limiting): add max messages per second configuration #4451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request introduces configuration for the rate limit for the number of messages sent per second, per notification type (such as SMS or voice). The new setting is exposed as a CLI flag and environment variable. This change allows operators to control and tune the message sending rate.
Configuration and CLI changes:
--max-msg-per-sec-per-typeand as the environment variableGOALERT_MAX_MSG_PER_SEC_PER_TYPE. Updated documentation to describe the new option. [1] [2]Which issue(s) this PR fixes:
Closes #4449