Tool for migrating from Lwt_log to Logs #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate programs using Lwt_log to the Logs library.
The same rules for detecting functions are used than in lwt-to-direct-style and are moved to [Ast_utils.rewrite_apply].
I couldn't reverse the order using the '@' operator after a few tries so inversing the order of operations. It's a little less nice with 'return' appearing at the first position but it works.
The channel is not closed in the generated code, so manual intervention is needed. 'set_close_on_exec' is no longer called on the fd.
Member
Author
|
This is successful: ocsigen/ocsigenserver#256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Written the same way as #1 and reusing as much code as possible.
Lwt_log's README indicate that its deprecated in favor ofLogs.Logshas less features out of the box for filtering and broadcasting logs but other than that is a 1:1 fit.