Skip to content

Add permissions#55

Merged
abonander merged 5 commits intomainfrom
fp/TCE-637
Jan 28, 2025
Merged

Add permissions#55
abonander merged 5 commits intomainfrom
fp/TCE-637

Conversation

@SharksT
Copy link
Contributor

@SharksT SharksT commented Dec 18, 2024

No description provided.

@SharksT SharksT changed the title [DRAFT] : Add ACL [Draft] : Add ACL Dec 18, 2024
@SharksT SharksT marked this pull request as draft December 18, 2024 18:53
@SharksT SharksT force-pushed the fp/TCE-637 branch 9 times, most recently from 9247b0e to a38b06f Compare December 24, 2024 17:28
@SharksT SharksT marked this pull request as ready for review December 24, 2024 17:34
@SharksT SharksT changed the title [Draft] : Add ACL Add ACL Dec 24, 2024
@SharksT SharksT requested a review from abonander December 24, 2024 17:34
Copy link

@abonander abonander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of the "ACL" initialism here and just use "permissions":

  • It's more obvious at a glance.
  • Some users might not know what ACL means and Googling initialisms sucks.
  • It better matches the table structure in the TOML file.

@SharksT SharksT changed the title Add ACL Add permissions Jan 27, 2025
@SharksT
Copy link
Contributor Author

SharksT commented Jan 27, 2025

Let's get rid of the "ACL" initialism here and just use "permissions":

* It's more obvious at a glance.

* Some users might not know what ACL means and Googling initialisms sucks.

* It better matches the table structure _in_ the TOML file.

Done

@abonander
Copy link

Unfortunately CI is broken for this repo now until we get it ported over to the new runners.

@abonander abonander merged commit 1317664 into main Jan 28, 2025
9 checks passed
@abonander abonander deleted the fp/TCE-637 branch January 28, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants