Skip to content

Commit a2ce0f8

Browse files
Clean up the patch of all debugs
1 parent 2eff472 commit a2ce0f8

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

src/taskgraph/util/verify.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,11 @@ def verify_trust_domain_v2_routes(
172172

173173
for route in routes:
174174
if route.startswith(route_prefix):
175+
# Check for invalid / in the route
176+
if "/" in route:
177+
raise Exception(
178+
f"{task.label} has invalid route with forward slash: {route}"
179+
)
175180
if route in scratch_pad:
176181
raise Exception(
177182
f"conflict between {task.label}:{scratch_pad[route]} for route: {route}"
@@ -206,14 +211,11 @@ def verify_routes_notification_filters(
206211
)
207212
task_dict = task.task
208213
routes = task_dict.get("routes", [])
209-
print(f"DEBUG: Task {task.label} routes: {routes}")
210214

211215
for route in routes:
212-
print(f"DEBUG: Checking route: {route}")
213216
if route.startswith(route_prefix):
214-
# Check for invalid characters in the route
217+
# Check for invalid / in the route
215218
if "/" in route:
216-
print(f"DEBUG: Found slash in route: {route}")
217219
raise Exception(
218220
f"{task.label} has invalid route with forward slash: {route}"
219221
)

test/test_util_verify.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,11 @@ def make_task_treeherder(label, symbol, platform="linux/opt"):
204204
make_graph(
205205
make_task(
206206
"invalid_slash",
207-
task_def={"routes": ["notify.email.default@email/address.on-completed"]},
207+
task_def={
208+
"routes": [
209+
"[email protected]/address2.on-completed"
210+
]
211+
},
208212
),
209213
),
210214
Exception,

0 commit comments

Comments
 (0)