Only consider tracked files when building toolchain hashes #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@glandium fyi |
ahal
force-pushed
the
ahal/push-msspxqnkkmvx
branch
2 times, most recently
from
ef374ea to
3084558
Compare
Collaborator
Author
|
Note that |
ahal
force-pushed
the
ahal/push-msspxqnkkmvx
branch
from
3084558 to
69df132
Compare
bhearsum
approved these changes
Mar 25, 2025
Contributor
|
Thanks for the work on this, this will be a big quality of life improvement for translations! |
bhearsum
added a commit
to bhearsum/taskgraph
that referenced
this pull request
Jul 22, 2025
Since taskcluster#664 we started returning paths relative to the repository root from `_find_matching_files`. This meant that when we join `base_path` with `path` in `hash_paths`, we end up with `base_path` in there twice. Fixing this without breaking `mozpath.match` means we need to join together the repository root and matched files after `mozpatch.match`. This, in turn, requires that some tests are able to call `get_repository`, which requires faking a repository being present.
bhearsum
added a commit
to bhearsum/taskgraph
that referenced
this pull request
Jul 22, 2025
Since taskcluster#664 we started returning paths relative to the repository root from `_find_matching_files`. This meant that when we join `base_path` with `path` in `hash_paths`, we end up with `base_path` in there twice. Fixing this without breaking `mozpath.match` means we need to join together the repository root and matched files after `mozpatch.match`. This, in turn, requires that some tests are able to call `get_repository`, which requires faking a repository being present.
bhearsum
added a commit
to bhearsum/taskgraph
that referenced
this pull request
Jul 22, 2025
Since taskcluster#664 we started returning paths relative to the repository root from `_find_matching_files`. This meant that when we join `base_path` with `path` in `hash_paths`, we end up with `base_path` in there twice. Fixing this without breaking `mozpath.match` means we need to join together the repository root and matched files after `mozpatch.match`. This, in turn, requires that some tests are able to call `get_repository`, which requires faking a repository being present.
bhearsum
added a commit
to bhearsum/taskgraph
that referenced
this pull request
Jul 22, 2025
Since taskcluster#664 we started returning paths relative to the repository root from `_find_matching_files`. This meant that when we join `base_path` with `path` in `hash_paths`, we end up with `base_path` in there twice. Fixing this without breaking `mozpath.match` means we need to join together the repository root and matched files after `mozpatch.match`. This, in turn, requires that some tests are able to call `get_repository`, which requires faking a repository being present.
bhearsum
added a commit
that referenced
this pull request
Jul 23, 2025
Since #664 we started returning paths relative to the repository root from `_find_matching_files`. This meant that when we join `base_path` with `path` in `hash_paths`, we end up with `base_path` in there twice. Fixing this without breaking `mozpath.match` means we need to join together the repository root and matched files after `mozpatch.match`. This, in turn, requires that some tests are able to call `get_repository`, which requires faking a repository being present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were walking the file system and were e.g scanning files in the
.gitdirectory. This can be quite slow on larger repos.Fixes #663