support discovering pyc/pyd/so modules #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you rebase onto last commit from master branch? I have updated a workflow, so tests should run after the update. |
Contributor
Author
|
Sure, can you run the tests now? |
s3rius
previously approved these changes
Dec 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
==========================================
- Coverage 77.51% 77.40% -0.11%
==========================================
Files 62 62
Lines 1899 1899
==========================================
- Hits 1472 1470 -2
- Misses 427 429 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Run |
Contributor
Author
Done. |
s3rius
approved these changes
Dec 26, 2024
s3rius
pushed a commit
that referenced
this pull request
Apr 4, 2025
* support discovering pyc/pyd/so modules * fix lint error * add trailing comma
s3rius
pushed a commit
that referenced
this pull request
Apr 4, 2025
* support discovering pyc/pyd/so modules * fix lint error * add trailing comma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used Cython to compile the .py files into .so files. However, taskiq can only automatically discover .py files, so I added support for .pyc, .pyd, and .so files.