Fixed shutdowns. #425
Merged
Fixed shutdowns. #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the way shutdowns are being invoked.
The behavior before this change was correct in previous versions of the shutdown logic. However, I updated the way shutdown events are propagated in #381, and since then, the broker has stopped propagating the
KeyboardInterruptexception. As a result, theshutdown()method was not being called.Fun observation: the hard-kill logic still throws a
KeyboardInterruptexception, and if the hard-kill is triggered quickly enough, the shutdown will occur correctly.Fixes #424.