refactor(movies): update to ng17, rxa 17, eslint #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BioPhoton
commented
Nov 12, 2023
projects/movies/src/app/pages/movie-list-page/movie-list-page.adapter.ts
Outdated
Show resolved
Hide resolved
|
Visit the preview URL for this PR (updated for commit c998cac): https://angular-movies-a12d3--update-to-ng17-w2uueccr.web.app (expires Sun, 07 Apr 2024 12:51:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f5e1819659ee450e0b7241d53391169f76c6f1d4 |
JeanMeche
reviewed
Nov 12, 2023
JeanMeche
reviewed
Nov 12, 2023
JeanMeche
reviewed
Nov 12, 2023
JeanMeche
reviewed
Nov 12, 2023
Closed
JeanMeche
reviewed
Nov 12, 2023
projects/movies/src/app/ui/pattern/star-rating/star-rating.component.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
Can we look to get the v17 migration merged ? :) |
related ssr function and hosting need to be together
…s up functions serving
…ersions, enable zoneless, enable view transition api
eneajaho
changed the title
refactor(movies): migrate to use application builder SSR features
eneajaho
approved these changes
Mar 8, 2024
Collaborator
|
Icons are not working on Firebase. But they work locally. Probably because of prerendering happening at build time. |
Collaborator
|
any updates on this? :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
package.jsonoverwritesPossible in a follow up PR: