added check if market is open at this moment in utils #288
Merged
Graeme22 merged 3 commits intotastyware:masterfrom Dec 18, 2025
Merged
added check if market is open at this moment in utils #288Graeme22 merged 3 commits intotastyware:masterfrom
Graeme22 merged 3 commits intotastyware:masterfrom
Conversation
Graeme22
requested changes
Dec 8, 2025
tastytrade/utils.py
Outdated
| Returns: | ||
| bool: True if market is open now, False otherwise | ||
| """ | ||
| now_est = datetime.now(TZ) |
Member
There was a problem hiding this comment.
This can be just now_in_new_york()
tastytrade/utils.py
Outdated
| bool: True if market is open now, False otherwise | ||
| """ | ||
| now_est = datetime.now(TZ) | ||
| return is_market_open_on(now_est.date()) and ( |
Member
There was a problem hiding this comment.
This doesn't work when there are half days. Perhaps prefer using the already included market_sessions module?
Contributor
Author
|
@Graeme22 changes implemented as suggested. Works now also on half-days like Black Friday. Tests are updated as well. |
Member
|
Thanks, sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s)
Added a util not a fix
Pre-merge checklist
make lint)make test, make sure you haveTT_REFRESH,TT_SECRET, andTT_ACCOUNTenvironment variables set)-- Only tested the added util. Very simple code, shouldn't break anything. tastytrade.utils completely tested including new fucntion
Please note that, in order to pass the tests, you'll need to set up your Tastytrade credentials as repository secrets on your local fork. Read more at CONTRIBUTING.md.