Fixing what looks to be a small bug#2
Fixing what looks to be a small bug#2neilcampbell wants to merge 2 commits intotathamoddie:masterfrom
Conversation
…al time than the configured circuit breaker threshold before going into the open circuit state.
|
Howdy. Looks good at a glance. Hold up is that I need to get a proper build and release process going for this repo. (It’s pretty old.) Will try and get to that soon. From: Neil Campbell [mailto:notifications@github.com] The operation passed into Execute/ExecuteWithRetries seems to be invoked 1 additional time than the configured circuit breaker threshold before going into the open circuit state. I don't think this is the desired behavior. This PR should fix it. You can merge this Pull Request by running git pull https://github.com/neilcampbell/reliability-patterns master Or view, comment on, or merge it at: Commit Summary
File Changes
Patch Links:
— |
|
No problems! |
|
@tathamoddie How are you going with the release stuff? |
|
@tathamoddie Any progress on this one? |
|
@tathamoddie any chance to merge this PR ? |
The operation passed into Execute/ExecuteWithRetries seems to be invoked 1 additional time than the configured circuit breaker threshold before going into the open circuit state. I don't think this is the desired behavior.
This PR should fix it.
The tests will also log some info to the console to help give context.