Adjust on stream

[dgateles]

Prevent gulp stops execution when test abort. New option: abortOnFailure(bool).

[tatsuyafw]

@dgateles

Thanks for this PR!
I would be glad if you also update the README.

[tatsuyafw]

I think when stream is undefined, calling stream.emit fails.

How about the following code:

if (stream) {
  if (options.abortOnFailure) {
     stream.emit('end');
  } else if (code) {
     stream.emit('error', new PluginError(PLUGIN_NAME, 'nightwatch exited with code ' + code));
  } else {
     stream.emit('end');
  } 
}

[dgateles]

That's right, I did the reverse.
False by default, it issues End of Error instead.

[tatsuyafw]

Sorry, the above code I wrote is wrong...
The below code is a correct example:

if (stream) {
  if (code && options.abortOnFailure) {
     stream.emit('error', new PluginError(PLUGIN_NAME, 'nightwatch exited with code ' + code));
  } else {
     stream.emit('end');
  } 
}

I think when stream is undefined, calling stream.emit fails.

I care about that if options.abortOnFailure is true and stream is undefined at the line 37 condition, Uncaught TypeError: Cannot read property 'emit' of undefined occurs at the line 44.

gulp-nightwatch/index.js

Lines 37 to 45 in dddef70

	if(options.abortOnFailure === true && stream) {
	if (code) {
	stream.emit('error', new PluginError(PLUGIN_NAME, 'nightwatch exited with code ' + code));
	} else {
	stream.emit('end');
	}
	} else {
	stream.emit('end');
	}