Enable pruning downloaded models #71

ashtonmeuser · 2025-09-24T20:16:34Z

This adds a static pruneModels(in:excluding:) method to DownloadModel.

Addresses #63.

This allows for maintaining a single canonical model in an app via:

let model = LLMSession.DownloadModel.llama(
    id: "Qwen/Qwen2.5-1.5B-Instruct-GGUF",
    model: "qwen2.5-1.5b-instruct-q4_k_m.gguf",
)

LLMSession.DownloadModel.pruneModels(excluding: [model])

gemini-code-assist · 2025-09-24T20:16:47Z

Summary of Changes

Hello @ashtonmeuser, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new capability to efficiently manage downloaded language models by allowing applications to prune (delete) models that are no longer needed. This is achieved through a new static method that can remove all models in a given directory except for a specified set, ensuring that only desired models are retained and storage is optimized. This feature directly addresses the need for better storage management for downloaded models.

Highlights

Model Pruning Functionality: Introduced a static pruneModels(in:excluding:) method within LLMSession.DownloadModel to enable the removal of downloaded models, excluding specified ones, directly addressing issue Expose a way to manage downloaded models #63.
Directory Cleanup Utility: Added a recursive removeEmptyFolders() extension to URL to efficiently clean up empty directories after model pruning operations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a useful feature for pruning downloaded models to manage storage. The implementation is mostly solid, with a new pruneModels static method on LLMSession.DownloadModel and a helper removeEmptyFolders extension on URL.

My review includes a few suggestions to improve performance, correctness, and error handling:

Using a Set for excluded models to speed up lookups.
Ensuring all model types with a path are handled correctly during pruning.
Improving error propagation by avoiding try? where it can mask issues.

These changes will make the pruning feature more robust and efficient.

Sources/LocalLLMClientCore/LLMSession.swift

Sources/LocalLLMClientUtility/URL+.swift

Sources/LocalLLMClientCore/LLMSession.swift

tattn

@ashtonmeuser Thank you for this PR!
After reviewing it, I think the interface looks good 😄
Once the review points are addressed, I’d like to go ahead and merge it.

If possible, it would also be great to add some tests.

Sources/LocalLLMClientCore/LLMSession.swift

Sources/LocalLLMClientUtility/URL+.swift

Sources/LocalLLMClientCore/LLMSession.swift

ashtonmeuser · 2025-09-25T15:40:31Z

Sources/LocalLLMClientUtility/FileManager+.swift

+        let excludingURLsNormalized: Set<URL> = Set(excludingURLs.map { $0.resolvingSymlinksInPath().standardizedFileURL
+        })


URL normalization done in FileManager.removeAllItems. Could be done outside instead.

ashtonmeuser · 2025-09-25T15:42:01Z

Sources/LocalLLMClientUtility/FileManager+.swift

+            }
+        }
+
+        if removingEmptyDirectories { try removeEmptyDirectories(in: url) }


Added argument to optionally skip pruning empty directories.

ashtonmeuser · 2025-09-25T15:45:35Z

Sources/LocalLLMClientCore/LLMSession.swift

+                switch model {
+                case let model as LLMSession.DownloadModel: model.modelPath
+                case let model as LLMSession.LocalModel: model.modelPath
+                default: nil
+                }


It might make sense for these models (DownloadModel and LocalModel) to share a protocol to avoid weird cases like this. Especially given that they share so much in common it's a bit odd for them to be siblings with redefined properties e.g. modelPath.

You’re absolutely right. I’d like to refactor this in the future.

ashtonmeuser · 2025-09-25T15:56:35Z

@ashtonmeuser Thank you for this PR! After reviewing it, I think the interface looks good 😄 Once the review points are addressed, I’d like to go ahead and merge it.

If possible, it would also be great to add some tests.

Comments addressed. I'm having some troubles running the tests locally but will continue trying in order to add tests.

tattn · 2025-09-26T04:01:16Z

APIs and logic look good to me. Thank you so much for addressing the review comments! 😄
I’ll go ahead and merge this after the tests are added. Please let me know if any troubles remain unresolved.

Enable pruning downloaded models

689fd16

gemini-code-assist bot reviewed Sep 24, 2025

View reviewed changes

Sources/LocalLLMClientCore/LLMSession.swift Outdated Show resolved Hide resolved

Sources/LocalLLMClientUtility/URL+.swift Outdated Show resolved Hide resolved

Sources/LocalLLMClientCore/LLMSession.swift Outdated Show resolved Hide resolved

ashtonmeuser commented Sep 24, 2025

View reviewed changes

Sources/LocalLLMClientCore/LLMSession.swift Outdated Show resolved Hide resolved

ashtonmeuser mentioned this pull request Sep 24, 2025

Expose a way to manage downloaded models #63

Open

ashtonmeuser added 2 commits September 24, 2025 14:59

Allow LocalModel to be excluded from prune

2f8c984

PR suggestions

1256c61

tattn reviewed Sep 25, 2025

View reviewed changes

Sources/LocalLLMClientCore/LLMSession.swift Outdated Show resolved Hide resolved

Sources/LocalLLMClientUtility/URL+.swift Outdated Show resolved Hide resolved

Sources/LocalLLMClientCore/LLMSession.swift Outdated Show resolved Hide resolved

ashtonmeuser added 3 commits September 25, 2025 08:29

Update signature

28999b2

Move empty directory pruning logic

fc303c6

Move core logic to FIleManager extension

857256e

ashtonmeuser commented Sep 25, 2025

View reviewed changes

		let excludingURLsNormalized: Set<URL> = Set(excludingURLs.map { $0.resolvingSymlinksInPath().standardizedFileURL
		})

Uh oh!

Enable pruning downloaded models #71

Are you sure you want to change the base?

Enable pruning downloaded models #71

Uh oh!

Conversation

ashtonmeuser commented Sep 24, 2025

Uh oh!

gemini-code-assist bot commented Sep 24, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tattn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ashtonmeuser Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ashtonmeuser Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

ashtonmeuser Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

tattn Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

ashtonmeuser commented Sep 25, 2025

Uh oh!

tattn commented Sep 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ashtonmeuser Sep 25, 2025 •

edited

Loading