Remove Inverse mod

osu.Game.Rulesets.Tau.Tests/TestSceneKiaiEffects.cs

@@ -41,11 +41,6 @@ public void SetUp()
         [TestCase(true)]
         public void TestEffect(bool isInversed)
         {
-            AddStep("Set inverse effect", () =>
-            {
-                Properties.InverseModEnabled.Value = isInversed;
-            });
-
             AddStep("Add beat result",
                 () => KiaiContainer.OnNewResult(
                     new DrawableBeat(new Beat()), new JudgementResult(new Beat(), new TauJudgement()) { Type = HitResult.Great }));

osu.Game.Rulesets.Tau/Mods/TauModHidden.cs

@@ -1,6 +1,5 @@
 using System;
 using System.ComponentModel;
-using System.Linq;
 using System.Runtime.InteropServices;
 using JetBrains.Annotations;
 using osu.Framework.Allocation;
@@ -27,7 +26,6 @@ public abstract class TauModHidden : ModHidden, IApplicableToDrawableRuleset<Tau
     {
         public override string Name => Mode.GetDescription();
         public override double ScoreMultiplier => 1.06;
-        public override Type[] IncompatibleMods => base.IncompatibleMods.Concat(new[] { typeof(TauModInverse) }).ToArray();
 
         public void ApplyToDrawableRuleset(DrawableRuleset<TauHitObject> drawableRuleset)
         {

osu.Game.Rulesets.Tau/Objects/Drawables/DrawableBeat.cs

@@ -48,10 +48,6 @@ protected override void UpdateInitialTransforms()
             base.UpdateInitialTransforms();
 
             DrawableBox.FadeIn(HitObject.TimeFadeIn);
-
-            if (Properties != null && Properties.InverseModEnabled.Value)
-                DrawableBox.MoveToY(-1.0f);
-
             DrawableBox.MoveToY(-0.5f, HitObject.TimePreempt);
         }
 
@@ -71,9 +67,6 @@ protected override void UpdateHitStateTransforms(ArmedState state)
             const double time_fade_hit = 250, time_fade_miss = 400;
             var offset = new Vector2(0, -.1f);
 
-            if (Properties != null && Properties.InverseModEnabled.Value)
-                offset.Y = -offset.Y;
-
             switch (state)
             {
                 case ArmedState.Hit:

osu.Game.Rulesets.Tau/Objects/Drawables/DrawableHardBeat.cs

@@ -44,10 +44,6 @@ protected override void UpdateInitialTransforms()
             base.UpdateInitialTransforms();
 
             this.FadeIn(HitObject.TimeFadeIn);
-
-            if (properties != null && properties.InverseModEnabled.Value)
-                this.ResizeTo(2);
-
             this.ResizeTo(1, HitObject.TimePreempt);
         }
 
@@ -59,13 +55,7 @@ protected override void UpdateHitStateTransforms(ArmedState state)
             base.UpdateHitStateTransforms(state);
 
             const double time_fade_hit = 250, time_fade_miss = 400;
-            float scaleHit = 1.25f, scaleMiss = 1.1f;
-
-            if (properties != null && properties.InverseModEnabled.Value)
-            {
-                scaleHit = 0.75f;
-                scaleMiss = 0.9f;
-            }
+            const float scale_hit = 1.25f, scale_miss = 1.1f;
 
             switch (state)
             {
@@ -75,15 +65,15 @@ protected override void UpdateHitStateTransforms(ArmedState state)
                     break;
 
                 case ArmedState.Hit:
-                    this.ScaleTo(scaleHit, time_fade_hit, Easing.OutQuint)
+                    this.ScaleTo(scale_hit, time_fade_hit, Easing.OutQuint)
                         .FadeColour(colour.ForHitResult(Result.Type), time_fade_hit, Easing.OutQuint)
                         .FadeOut(time_fade_hit);
 
                     break;
 
                 case ArmedState.Miss:
                     this.FadeColour(Color4.Red, time_fade_miss, Easing.OutQuint)
-                        .ResizeTo(scaleMiss, time_fade_hit, Easing.OutQuint)
+                        .ResizeTo(scale_miss, time_fade_hit, Easing.OutQuint)
                         .FadeOut(time_fade_miss);
 
                     break;

osu.Game.Rulesets.Tau/Objects/Drawables/DrawableSlider.Calculations.cs

@@ -27,9 +27,7 @@ private void updatePath()
 
             float radius = TauPlayfield.BASE_SIZE.X / 2;
 
-            float distanceAt(double t) => inversed
-                                              ? (float)(2 * radius - (time - t) / HitObject.TimePreempt * radius)
-                                              : (float)((time - t) / HitObject.TimePreempt * radius);
+            float distanceAt(double t) => (float)((time - t) / HitObject.TimePreempt * radius);
 
             void addVertex(double t, double angle)
             {

osu.Game.Rulesets.Tau/Objects/Drawables/DrawableSlider.Graphics.SliderPathDrawNode.cs

@@ -70,11 +70,8 @@ private record struct SliderUniform
                     public UniformVector4 HitColor;
                     public UniformFloat Range;
                     public UniformFloat FadeRange;
-                    public UniformBool Reverse;
 
-                    private UniformPadding4 _p2;
-                    private UniformPadding12 _p3;
-                    private UniformPadding4 _p4;
+                    private UniformPadding8 _p2;
                 }
 
                 // We multiply the size param by 3 such that the amount of vertices is a multiple of the amount of vertices
@@ -92,7 +89,6 @@ public SliderPathDrawNode(SliderPath source)
                 private Vector2 centerPos;
                 private float range;
                 private float fadeRange;
-                private bool reverse;
 
                 public override void ApplyState()
                 {
@@ -128,7 +124,6 @@ public override void ApplyState()
                     fadeRange = (Source.ToScreenSpace(fade) - centerPos).Length - range;
                     var c = Source.FadeColour;
                     hitColour = new Vector4(c.R, c.G, c.B, c.A);
-                    reverse = Source.Reverse;
                 }
 
                 private Vector2 pointOnCircle(float angle) => new(MathF.Sin(angle), -MathF.Cos(angle));
@@ -346,7 +341,6 @@ protected override void Draw(IRenderer renderer)
                         Range = range,
                         FadeRange = fadeRange,
                         HitColor = hitColour,
-                        Reverse = reverse
                     };
 
                     //maskData ??= renderer.CreateUniformBuffer<MaskUniform>();

osu.Game.Rulesets.Tau/Objects/Drawables/DrawableSlider.Graphics.cs

@@ -64,7 +64,6 @@ public IReadOnlyList<Vector3> Vertices
 
             private float pathRadius = 10f;
             public Colour4 FadeColour;
-            public bool Reverse;
 
             /// <summary>
             /// How wide this path is on each side of the line.

osu.Game.Rulesets.Tau/Objects/Drawables/DrawableSlider.cs

@@ -46,8 +46,6 @@ public partial class DrawableSlider : DrawableAngledTauHitObject<Slider>
         private readonly Cached drawCache = new();
         private readonly PausableSkinnableSound slidingSample;
 
-        private bool inversed;
-
         public DrawableSlider()
             : this(null)
         {
@@ -159,14 +157,6 @@ protected override void OnApply()
             path.FadeColour = colour.ForHitResult(HitResult.Great);
 
             totalTimeHeld = 0;
-
-            if (properties.InverseModEnabled.Value)
-            {
-                inversed = true;
-                maskingContainer.Masking = false;
-                path.Reverse = inversed;
-                // PathDistance = path.PathDistance = TauPlayfield.BaseSize.X;
-            }
         }
 
         protected override void OnFree()

osu.Game.Rulesets.Tau/Objects/Drawables/DrawableSliderRepeat.cs

@@ -101,8 +101,6 @@ protected override void OnApply()
         {
             base.OnApply();
 
-            DrawableBox.Y = Properties?.InverseModEnabled.Value == true ? -1.0f : 0;
-
             DrawableBox.Alpha = 0;
         }
 
@@ -120,9 +118,6 @@ protected override void UpdateHitStateTransforms(ArmedState state)
             float velocity = -0.5f / (float)HitObject.TimePreempt;
             float timeFadeHit = DrawableSlider.FADE_RANGE / Math.Abs(velocity);
 
-            if (Properties?.InverseModEnabled.Value == true)
-                velocity *= -1;
-
             switch (state)
             {
                 case ArmedState.Hit or ArmedState.Miss:

osu.Game.Rulesets.Tau/Objects/Drawables/DrawableStrictHardBeat.cs

@@ -71,10 +71,6 @@ protected override void UpdateInitialTransforms()
             base.UpdateInitialTransforms();
 
             this.FadeIn(HitObject.TimeFadeIn);
-
-            if (properties != null && properties.InverseModEnabled.Value)
-                piece.ResizeTo(2);
-
             piece.ResizeTo(1, HitObject.TimePreempt);
         }
 
@@ -86,13 +82,7 @@ protected override void UpdateHitStateTransforms(ArmedState state)
             base.UpdateHitStateTransforms(state);
 
             const double time_fade_hit = 250, time_fade_miss = 400;
-            float scaleHit = 1.25f, scaleMiss = 1.1f;
-
-            if (properties != null && properties.InverseModEnabled.Value)
-            {
-                scaleHit = 0.75f;
-                scaleMiss = 0.9f;
-            }
+            const float scale_hit = 1.25f, scale_miss = 1.1f;
 
             switch (state)
             {
@@ -102,15 +92,15 @@ protected override void UpdateHitStateTransforms(ArmedState state)
                     break;
 
                 case ArmedState.Hit:
-                    this.ScaleTo(scaleHit, time_fade_hit, Easing.OutQuint)
+                    this.ScaleTo(scale_hit, time_fade_hit, Easing.OutQuint)
                         .FadeColour(colour.ForHitResult(Result.Type), time_fade_hit, Easing.OutQuint)
                         .FadeOut(time_fade_hit);
 
                     break;
 
                 case ArmedState.Miss:
                     this.FadeColour(Color4.Red, time_fade_miss, Easing.OutQuint)
-                        .ResizeTo(scaleMiss, time_fade_hit, Easing.OutQuint)
+                        .ResizeTo(scale_miss, time_fade_hit, Easing.OutQuint)
                         .FadeOut(time_fade_miss);
 
                     break;

osu.Game.Rulesets.Tau/Objects/Drawables/DrawableTauJudgement.cs

@@ -5,7 +5,6 @@
 using osu.Game.Rulesets.Scoring;
 using osu.Game.Rulesets.Tau.Configuration;
 using osu.Game.Rulesets.Tau.Objects.Drawables.Pieces;
-using osu.Game.Rulesets.Tau.UI;
 using osuTK;
 
 namespace osu.Game.Rulesets.Tau.Objects.Drawables
@@ -39,13 +38,6 @@ public DrawableTauJudgement()
             });
         }
 
-        [BackgroundDependencyLoader(true)]
-        private void load(TauCachedProperties properties)
-        {
-            if (properties != null && properties.InverseModEnabled.Value)
-                distance = 0.4f;
-        }
-
         public override void Apply(JudgementResult result, DrawableHitObject judgedObject)
         {
             base.Apply(result, judgedObject);

osu.Game.Rulesets.Tau/Resources/Shaders/sh_Slider.fs

@@ -13,7 +13,6 @@ layout(std140, set = 0, binding = 0) uniform m_sliderParameters {
     highp vec4 hitColor;
     highp float range;
     highp float fadeRange;
-    bool reverse;
 };
 
 layout(set = 1, binding = 0) uniform lowp texture2D m_texture;
@@ -28,7 +27,7 @@ void main(void)
     vec2 diff = v_Position - centerPos;
     float dist = sqrt(diff.x * diff.x + diff.y * diff.y);
 
-    if ( reverse != dist <= range ) 
+    if ( dist <= range ) 
     {
         o_colour = colour;
     } 

osu.Game.Rulesets.Tau/TauRuleset.cs

@@ -88,7 +88,6 @@ public override IEnumerable<Mod> GetModsFor(ModType type)
                 {
                     new MultiMod(new ModWindUp(), new ModWindDown()),
                     new ModAdaptiveSpeed(),
-                    new TauModInverse(),
                     new TauModImpossibleSliders(),
                     new TauModRoundabout(),
                     new TauModNoScope(),

osu.Game.Rulesets.Tau/UI/Effects/ClassicKiaiEffect.cs

@@ -49,7 +49,7 @@ protected override void ApplyHitAnimation(Drawable particle)
         private void addTransformsForAngled(Drawable particle)
         {
             particle.MoveTo(Extensions.FromPolarCoordinates(
-                             (RNG.NextSingle() * 0.15f) * (Settings.Inversed ? -1f : 1f) + Distance,
+                             RNG.NextSingle() * 0.15f + Distance,
                              RNG.NextSingle(Settings.Angle - 10, Settings.Angle + 10)),
                          Duration, Easing.OutQuint)
                     .ResizeTo(new Vector2(RNG.Next(0, 5)), Duration, Easing.OutQuint);
@@ -59,7 +59,7 @@ private void addTransformsForCircular(Drawable particle)
         {
             particle.MoveTo(
                          Extensions.FromPolarCoordinates(
-                             (RNG.NextSingle() * 0.15f) * (Settings.Inversed ? -1f : 2f) + Distance,
+                             (RNG.NextSingle() * 0.15f) * 2f + Distance,
                              Vector2.Zero.GetDegreesFromPosition(particle.Position)), Duration,
                          Easing.OutQuint)
                     .ScaleTo(new Vector2(RNG.Next(1, 2)), Duration, Easing.OutQuint);