feat: add CefAppProtocol bindings and partially port SimpleApplication from original cefsimple #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Rust bindings for the Objective-C protocols required for proper application handling on macOS (CrAppProtocol, CrAppControlProtocol, and CefAppProtocol) using the objc2 crate. These bindings are necessary to correctly implement an NSApplication subclass, which is a foundational step for porting the official cefsimple application logic and fixing related crashes. Refs: tauri-apps#96
Adds SimpleApplication implementing CefAppProtocol. Refs: tauri-apps#96
Updates the cefsimple example on macOS to use the new `cef::application_mac::SimpleApplication`. This properly initializes the application instance, resolving the crash that previously occurred during right-click events. Refs: tauri-apps#96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is related #96.
It partially ports SimpleApplication from original cefsimple, and resolves right-click crush on macOS.
By the way, I realized my first commit message,
feat: port SimpleApplication from original cefsimple, might be slightly misleading. This is a partial port to fix the right-click issue, not a full port of SimpleApplication. It contains missing features such as-terminate:method andSimpleAppDelegate.Would you prefer if I rebased to update the commit message to be more precise (e.g., partially port...)? Or are you happy to merge it as is, perhaps squashing and editing the message on your end?
I'm happy to do whatever is easiest for you. Thanks.