fix(fs): can't use Windows path #1710
Conversation
Package Changes Through 3c53ac6There are 3 changes which include dialog with prerelease, window-state with prerelease, fs with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| Path(SafePathBuf), | ||
| } | ||
|
|
||
| impl<'de> serde::Deserialize<'de> for SafeFilePath { |
There was a problem hiding this comment.
I see that we have a duplicated enum definition with and now same deserialize implementation, maybe we can combine this logic into one, by using generics? and still export aliases without a generic:
enum FilePathOrUrl<T: FromStr> {
Url(url::Url),
Path(T),
}
pub type SafeFilePath = FilePath<SafeFilePath>;
pub type FilePath = FilePath<PathBuf>;There was a problem hiding this comment.
enum FilePathOrUrl<T: FromStr> { Url(url::Url), Path(T), } pub type SafeFilePath = FilePath<SafeFilePath>; pub type FilePath = FilePath<PathBuf>;
I'm not sure how that'll work, SafeFilePath doesn't implement FromStr, and that means we either need to do it in tauri or we need a wrapper
There was a problem hiding this comment.
The best is to implement FromStr on in tauri. For now, we can just add a TODO then or merge as is.
|
Also I think we should add some tests in this PR, just to ensure we don't regress again |
* Fix fs can't use Windows path * Add change file * Implement `Deserialize` instead * Rename FilePath's visitor to FilePathVisitor * Add todo and test * Clippy * Unused variable
2 participants
Url deserializes Windows drive letter to url scheme which is not what we wanted, since we don't use single letter schemes anyways, we can just assume a single letter scheme url to be a path not a url
Fix #1704