Skip to content

Conversation

@Goodjooy
Copy link
Contributor

@Goodjooy Goodjooy commented Oct 14, 2024

this pr is the implement of #1930 .

tasks

  • skip migration if no migration provided in preload

@Goodjooy Goodjooy requested a review from a team as a code owner October 14, 2024 08:26
@FabianLars
Copy link
Member

Thanks for the PR! I don't think we should panic here. I think i would have went with simply replacing the unwrap() that caused the panic with unwrap_or_default() so preload is basically ignored if no migrations were set.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024

Package Changes Through 3bb7714

There are 8 changes which include dialog with patch, dialog-js with patch, positioner with patch, positioner-js with patch, http with patch, http-js with patch, shell with patch, shell-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.2 2.0.3
api-example-js 2.0.0 2.0.1
dialog 2.0.1 2.0.2
dialog-js 2.0.0 2.0.1
http 2.0.1 2.0.2
http-js 2.0.0 2.0.1
positioner 2.0.1 2.0.2
positioner-js 2.0.0 2.0.1
shell 2.0.1 2.0.2
shell-js 2.0.0 2.0.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Goodjooy
Copy link
Contributor Author

Thanks for the PR! I don't think we should panic here. I think i would have went with simply replacing the unwrap() that caused the panic with unwrap_or_default() so preload is basically ignored if no migrations were set.

This solution is really simpler and fits the semantics of the preload itself, the code change is done

@Goodjooy
Copy link
Contributor Author

Looks like CI is having trouble installing webkit2gtk. :(

@FabianLars
Copy link
Member

oh, github changed the default runners

@FabianLars FabianLars changed the title fix(SQL): user-friendly panic message when missing migration fix(sql): don't panic on missing migration when preload is enabled Oct 14, 2024
@FabianLars FabianLars merged commit aef5dd6 into tauri-apps:v2 Oct 14, 2024
15 checks passed
Sir-Thom pushed a commit to Sir-Thom/plugins-workspace that referenced this pull request Oct 22, 2024
gezihuzi pushed a commit to Hypobenthos/plugins-workspace that referenced this pull request Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL Plugin: The preload parameter has a potential migration requirement.

2 participants