feat(http): persist cookies on disk #1978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 3d8ce8eThere are 2 changes which include http with patch, http-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
changed the title
amrbashir
commented
Dec 9, 2024
amrbashir
commented
Dec 9, 2024
nicolaspapp
reviewed
Mar 4, 2025
plugins/http/src/lib.rs
Outdated
| let cache_dir = app.path().app_cache_dir()?; | ||
| std::fs::create_dir_all(&cache_dir)?; | ||
|
|
||
| let path = cache_dir.join("Cookies"); |
There was a problem hiding this comment.
Just FYI. I have been testing this and this part seems to break when the "Cookies" did not previously exist.
I changed it so it starts with an empty array in case the file is new:
let path = cache_dir.join("Cookies");
let file_exists = path.exists();
let mut file = File::options()
.create(true)
.append(true)
.read(true)
.open(&path)?;
if !file_exists {
// Initialize the file with an empty array
use std::io::Write;
file.write_all(b"[]")?;
}
lucasfernog
previously approved these changes
Mar 16, 2025
powell-newin
pushed a commit
to powell-newin/plugins-workspace
that referenced
this pull request
Mar 18, 2025
* enhance(http): persist cookies on disk closes tauri-apps/tauri#11518 * clippy * inline reqwest_cookie_store to fix clippy * clippy * Update .changes/persist-cookies.md * Update plugins/http/src/reqwest_cookie_store.rs * update example * fallback to empty store if failed to load * fix example * persist cookies immediately * clone * lint * .cookies filename * prevent race condition --------- Co-authored-by: Lucas Nogueira <[email protected]>
gezihuzi
pushed a commit
to Hypobenthos/plugins-workspace
that referenced
this pull request
Jun 22, 2025
* enhance(http): persist cookies on disk closes tauri-apps/tauri#11518 * clippy * inline reqwest_cookie_store to fix clippy * clippy * Update .changes/persist-cookies.md * Update plugins/http/src/reqwest_cookie_store.rs * update example * fallback to empty store if failed to load * fix example * persist cookies immediately * clone * lint * .cookies filename * prevent race condition --------- Co-authored-by: Lucas Nogueira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes tauri-apps/tauri#11518
closes #2375