Skip to content

feat(localhost): add custom host binding to allow external access #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2024
Merged

feat(localhost): add custom host binding to allow external access #1982

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ddc9f4
feat(localhost): add custom host binding to allow external access
arihav Oct 29, 2024
85d3706
rust fmt
arihav Oct 30, 2024
28467d9
Update plugins/localhost/src/lib.rs
arihav Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/localhost-custom-host-binding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'localhost': 'minor'
---

Add custom host binding to allow external access
10 changes: 9 additions & 1 deletion plugins/localhost/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,24 @@ type OnRequest = Option<Box<dyn Fn(&Request, &mut Response) + Send + Sync>>;

pub struct Builder {
port: u16,
host: Option<String>,
on_request: OnRequest,
}

impl Builder {
pub fn new(port: u16) -> Self {
Self {
port,
host: None,
on_request: None,
}
}

pub fn host<H: AsRef<str>>(mut self, host: H) -> Self {
self.host = Some(host.as_ref().to_string());
self
}

pub fn on_request<F: Fn(&Request, &mut Response) + Send + Sync + 'static>(
mut self,
f: F,
Expand All @@ -67,14 +74,15 @@ impl Builder {

pub fn build<R: Runtime>(mut self) -> TauriPlugin<R> {
let port = self.port;
let host = self.host.unwrap_or("localhost".to_string());
let on_request = self.on_request.take();

PluginBuilder::new("localhost")
.setup(move |app, _api| {
let asset_resolver = app.asset_resolver();
std::thread::spawn(move || {
let server =
Server::http(format!("localhost:{port}")).expect("Unable to spawn server");
Server::http(format!("{host}:{port}")).expect("Unable to spawn server");
for req in server.incoming_requests() {
let path = req
.url()
Expand Down
Loading