Skip to content

fix(clipboard-manager): read_image wrongly set the image rgba data with binary PNG data. #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix(clipboard-manager): read_image wrongly set the image rgba data with binary PNG data. #1986

merged 2 commits into from
Oct 30, 2024

Conversation

@RikaKagurasaka
Copy link
Contributor

@RikaKagurasaka RikaKagurasaka commented Oct 30, 2024

fix #1985

The dependency of image crate may be unnecessary now. I'm not sure whether it should be removed.

@RikaKagurasaka RikaKagurasaka requested a review from a team as a code owner October 30, 2024 12:49
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

Package Changes Through d661999

There are 4 changes which include sql-js with patch, clipboard-manager with patch, sql with patch, fs-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.4 2.0.5
api-example-js 2.0.1 2.0.2
clipboard-manager 2.0.1 2.0.2
fs-js 2.0.1 2.0.2
sql 2.0.1 2.0.2
sql-js 2.0.0 2.0.1

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

@amrbashir
Copy link
Member

amrbashir commented Oct 30, 2024

The dependency of image crate may be unnecessary now. I'm not sure whether it should be removed.

yeah looks like it, feel free to remove it

amrbashir
amrbashir requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a change file in .changes directory? also you need to run cargo fmt

@RikaKagurasaka
Copy link
Contributor Author

RikaKagurasaka commented Oct 30, 2024 •
edited
Loading

Could you add a change file in .changes directory? also you need to run cargo fmt

OK! I think I finished. Could you kindly approve another check workflow?

@amrbashir amrbashir merged commit d57df4d into tauri-apps:v2 Oct 30, 2024
16 checks passed
@amrbashir
Copy link
Member

amrbashir commented Oct 30, 2024

thank you

@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Merged
gezihuzi pushed a commit to Hypobenthos/plugins-workspace that referenced this pull request Jun 22, 2025
@RikaKagurasaka @gezihuzi
fix(clipboard-manager): read_image wrongly set the image rgba data …
c0fe66a 
…with binary PNG data. (tauri-apps#1986)

* fix(clipboard-manager): `read_image` wrongly set the image rgba data with binary PNG data.

* remove depencency of `image` crate; add patch file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[bug] [clipboard-manager] read_image wrongly set the image rgba data with binary PNG data.

2 participants

@RikaKagurasaka @amrbashir