fix(deep-link): Remove getCurrent call in onOpenUrl #2008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through c5ca148There are 2 changes which include deep-link with patch, deep-link-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
i did the same for the rust side, can revert if desired |
lucasfernog
approved these changes
Nov 9, 2024
gezihuzi
pushed a commit
to Hypobenthos/plugins-workspace
that referenced
this pull request
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I received multiple reports that this behavior causes issues, like when reloading pages or re-mounting components. It's also not the behavior people seem to expect. Also, the function docs actually told users to use getCurrent themselves.
I'm not 100% sure about the rust side. The issues you see on the rust side aren't as apparent and the docs are also correct there but i think it would make sense to also change it.