Skip to content

refactor(shell): Use &self instead of self to allow kill to be called multiple times. #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: v2
Choose a base branch
from
Open

refactor(shell): Use &self instead of self to allow kill to be called multiple times. #2224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
882ea43
refactor(shell): Use &self instead of self to allow kill to be called…
xuchaoqian Dec 19, 2024
126f5f4
feat(shell): add exit_status to get the child's exit status.
xuchaoqian Dec 19, 2024
bb8609f
Revert "feat(shell): add exit_status to get the child's exit status."
xuchaoqian Dec 19, 2024
dd59321
Create change-pr-2224.md
xuchaoqian Dec 19, 2024
c5205e1
chore(shell): add patch bump for JS package shell-js
xuchaoqian Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/change-pr-2224.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"shell": patch
"shell-js": patch
---

Use &self instead of self to allow kill to be called multiple times.
2 changes: 1 addition & 1 deletion plugins/shell/src/process/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ impl CommandChild {
}

/// Sends a kill signal to the child.
pub fn kill(self) -> crate::Result<()> {
pub fn kill(&self) -> crate::Result<()> {
self.inner.kill()?;
Ok(())
}
Expand Down
Loading