fix(opener): return error if path not exists #2253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 3e20861There are 4 changes which include opener with patch, opener-js with patch, updater with patch, updater-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
reviewed
Jan 2, 2025
betamos
force-pushed
the
opener-err
branch
2 times, most recently
from
350fe5a to
e76ebea
Compare
amrbashir
previously approved these changes
Jan 3, 2025
|
Thanks. Should be good to go. Let me know if there's something I need to do. |
amrbashir
reviewed
Jan 3, 2025
amrbashir
approved these changes
Jan 3, 2025
gezihuzi
pushed a commit
to Hypobenthos/plugins-workspace
that referenced
this pull request
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussion on Discord. This PR checks that the path exists before shelling out to the "launcher". This helps with the common error that a file doesn't exist, and thus cannot be opened.
This is needed because we open files & urls "detached" in a separate thread, so we can't alert users if the action failed.