Skip to content

Conversation

FabianLars
Copy link
Member

closes #2275

i was actually starting to work on #2277 🙃

I'm not sure about the other_response_fields name - suggestions are very welcome

@FabianLars FabianLars requested a review from a team as a code owner January 15, 2025 14:10
Copy link
Contributor

github-actions bot commented Jan 15, 2025

Package Changes Through 63dd977

There are 8 changes which include clipboard-manager with patch, clipboard-manager-js with patch, http with minor, http-js with minor, log with patch, log-js with patch, updater with minor, updater-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.15 2.0.16
api-example-js 2.0.11 2.0.12
clipboard-manager 2.2.0 2.2.1
clipboard-manager-js 2.2.0 2.2.1
http 2.2.0 2.3.0
http-js 2.2.0 2.3.0
log 2.2.0 2.2.1
log-js 2.2.0 2.2.1
updater 2.3.1 2.4.0
updater-js 2.3.1 2.4.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of calling it other_response_fields, let's call it raw_json and embed the whole JSON response and not just extra fields.

@FabianLars FabianLars marked this pull request as draft January 22, 2025 10:57
@FabianLars FabianLars marked this pull request as ready for review January 22, 2025 17:52
@amrbashir amrbashir merged commit 0afc9b6 into v2 Jan 23, 2025
22 checks passed
@amrbashir amrbashir deleted the feat/updater-unknown-fields branch January 23, 2025 00:54
gezihuzi pushed a commit to Hypobenthos/plugins-workspace that referenced this pull request Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom key for updater plugin
2 participants