Skip to content

fix(opener): invoke the mobile plugin in the commands too (#2234) #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2025
Merged

fix(opener): invoke the mobile plugin in the commands too (#2234) #2332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2d6a76
fix(opener): invoke the mobile plugin in the commands too (#2234)
betamos Jan 19, 2025
9a510dd
Merge branch 'v2' into opener-mobile
FabianLars Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/opener-mobile-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"opener": patch
"opener-js": patch
---

Fix broken JS commands `opener.openPath` and `opener.openUrl` on mobile.
6 changes: 3 additions & 3 deletions plugins/opener/src/commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use tauri::{
AppHandle, Runtime,
};

use crate::{scope::Scope, Error};
use crate::{scope::Scope, Error, OpenerExt};

#[tauri::command]
pub async fn open_url<R: Runtime>(
Expand All @@ -34,7 +34,7 @@ pub async fn open_url<R: Runtime>(
);

if scope.is_url_allowed(&url, with.as_deref()) {
crate::open_url(url, with)
app.opener().open_url(url, with)
} else {
Err(Error::ForbiddenUrl { url, with })
}
Expand Down Expand Up @@ -63,7 +63,7 @@ pub async fn open_path<R: Runtime>(
);

if scope.is_path_allowed(Path::new(&path), with.as_deref())? {
crate::open_path(path, with)
app.opener().open_path(path, with)
} else {
Err(Error::ForbiddenPath { path, with })
}
Expand Down
Loading