Skip to content

fix(single-instance): Check if pointer is null #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2025
Merged

fix(single-instance): Check if pointer is null #2452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41088ef
fix(single-instance): Check if pointer is null
FabianLars Feb 23, 2025
13b9a54
Update single-instance-nullpointer-deref.md
FabianLars Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/single-instance-nullpointer-deref.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
single-instance: patch
---

Fixed an issue that caused `null pointer dereference occurred` errors on rust nightly.
2 changes: 1 addition & 1 deletion plugins/process/permissions/schemas/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,4 +322,4 @@
]
}
}
}
}
5 changes: 5 additions & 0 deletions plugins/single-instance/src/platform_impl/windows.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ unsafe extern "system" fn single_instance_window_proc<R: Runtime>(
) -> LRESULT {
let data_ptr = GetWindowLongPtrW(hwnd, GWL_USERDATA)
as *mut (AppHandle<R>, Box<SingleInstanceCallback<R>>);

if data_ptr.is_null() {
return DefWindowProcW(hwnd, msg, wparam, lparam);
}

let (app_handle, callback) = &mut *data_ptr;

match msg {
Expand Down
Loading