feat(updater): improve tracing and error logging #2513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 50fba89There are 6 changes which include clipboard-manager with patch, clipboard-manager-js with patch, log with minor, log-js with minor, updater with patch, updater-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
approved these changes
Mar 9, 2025
| .map_err(Into::into) | ||
| { | ||
| Ok(release) => { | ||
| println!("parsed release response {release:?}"); |
There was a problem hiding this comment.
This should be log::debug as well?
gezihuzi
pushed a commit
to Hypobenthos/plugins-workspace
that referenced
this pull request
Jun 22, 2025
Comment on lines
+420
to
+422
| log::error!( | ||
| "update endpoint did not respond with a successful status code" | ||
| ); |
There was a problem hiding this comment.
Is this case missing a last_error?
Users are reporting that 400 errors are shown as "invalid json", even though the response should be hitting this success status check, and the body is still a valid json string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.