Skip to content

Conversation

adrieljss
Copy link
Contributor

@adrieljss adrieljss commented Mar 12, 2025

The problem was that the stream while sending was blocking the await function, not returning ReadableStream and the headers after sending.

This was fixed by (kind of) bringing back the fetch_read_body, I actually wanted to name it fetch_stream_body, but I don't know how to set up the permissions.

On ReadableStream start, it will call a different function (fetch_read_body) as to not block the return of the headers on fetch_send.

Fixes #2479 (comment)

@amrbashir

@adrieljss adrieljss requested a review from a team as a code owner March 12, 2025 02:05
@amrbashir
Copy link
Member

Can you please fix the conflicts?

And for future PRs, it is recommended not make PRs from the default branch as it most certainly will cause conflicts. You should always make a new branch for each PR.

@adrieljss
Copy link
Contributor Author

adrieljss commented Mar 12, 2025

Whoops
sorry I didn't know, I will resolve them soon. Thank you for the tip👍.

Copy link
Contributor

github-actions bot commented Mar 13, 2025

Package Changes Through bb74676

There are 2 changes which include http with minor, http-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.21 2.0.22
api-example-js 2.0.17 2.0.18
http 2.4.0 2.5.0
http-js 2.4.0 2.5.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@amrbashir
Copy link
Member

Also you need to run pnpm build

@adrieljss
Copy link
Contributor Author

Also you need to run pnpm build

I already ran it in the previous commits so it didn't change anything

@FabianLars
Copy link
Member

is your local node_modules instance outdated maybe? (or did you maybe just not commit the dist-js files?)

@adrieljss
Copy link
Contributor Author

adrieljss commented Mar 14, 2025

is your local node_modules instance outdated maybe? (or did you maybe just not commit the dist-js files?)

image
I think the compiled js is already correct, the build function doesnt change anything, I must have built it and commited while I was testing.

@FabianLars

This comment was marked as outdated.

@adrieljss
Copy link
Contributor Author

adrieljss commented Mar 14, 2025

i can push the diff for you if you prefer? then you don't have to recreate the branch

Nevermind, I ran it twice and then it changed this time, so weird.

amrbashir
amrbashir previously approved these changes Mar 15, 2025
@amrbashir amrbashir merged commit d3183aa into tauri-apps:v2 Mar 15, 2025
2 checks passed
gezihuzi pushed a commit to Hypobenthos/plugins-workspace that referenced this pull request Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants