Skip to content

fix(window-state): window size jump on multi monitor setup #2583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

fix(window-state): window size jump on multi monitor setup #2583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a50f608
fix: window size jump on multi monitor setup
Legend-Master Mar 31, 2025
d0ad83e
Add change file
Legend-Master Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/multi-monitor-window-state.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
window-state: patch
window-state-js: patch
---

Fix window size gets bigger/smaller on secondary monitor with a different scaling than the primary one
14 changes: 7 additions & 7 deletions plugins/window-state/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,13 +184,6 @@ impl<R: Runtime> WindowExt for Window<R> {
self.set_decorations(state.decorated)?;
}

if flags.contains(StateFlags::SIZE) {
self.set_size(PhysicalSize {
width: state.width,
height: state.height,
})?;
}

if flags.contains(StateFlags::POSITION) {
let position = (state.x, state.y).into();
let size = (state.width, state.height).into();
Expand All @@ -214,6 +207,13 @@ impl<R: Runtime> WindowExt for Window<R> {
}
}

if flags.contains(StateFlags::SIZE) {
self.set_size(PhysicalSize {
width: state.width,
height: state.height,
})?;
}

if flags.contains(StateFlags::MAXIMIZED) && state.maximized {
self.maximize()?;
}
Expand Down
Loading