-
Notifications
You must be signed in to change notification settings - Fork 431
refactor(fs): reduce overhead of watch
#2613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 0aa380cThere are 5 changes which include single-instance with patch, fs with minor, fs-js with minor, http with patch, http-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
in case user pass in an object containing it which is the case in our file system example page
amrbashir
reviewed
Apr 19, 2025
amrbashir
approved these changes
Apr 19, 2025
gezihuzi
pushed a commit
to Hypobenthos/plugins-workspace
that referenced
this pull request
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a few things
Resource
WatcherResource
andunwatch
as they're not needed,notify
's watcher will clean itself up on dropwatch
, as they're not really neededAlso:
close
command as it's not used anymoremetadata
tostat
in readmeuuid
as dependency since it's not used anymore