-
Notifications
You must be signed in to change notification settings - Fork 431
chore(notifications): regen lockfile bumping notify-rust to 4.11.7 to resolve panic on MacOS #2623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(notifications): regen lockfile bumping notify-rust to 4.11.7 to resolve panic on MacOS #2623
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ea316cb
to
26deda9
Compare
Seems based on the CI perhaps my version of rust is too recent? Advice welcome on how to manage that, I'm just running what we're using for our Tauri builds but perhaps I need to run something lower for generating the lockfile? Updated: Just working through the CI issues now - will use a rust toolchain to run using 1.77.2 |
The fix was in mac-notification-sys and notify-rust is not locking its version so the Cargo.toml change doesn't do anything really. If you remove the Cargo.toml change (we typically don't lock patch versions to give users a bit more freedom) and the changefile I'd still merge it because I like the lock file changes for ci |
Long week got to me! I'd originally intended it as enforcing a minimum version for MacOS rather than locking to the patch version, I appreciate that's not what my PR does. It seems desirable to me from an end user's perspective to ensure that the plugin doesn't resolve to a version of Would the tauri team agree on that, or do you prefer to leave it totally open and assume that the end-user will be retrieving the latest version of |
0a0884a
to
45940f9
Compare
In theory i'd be open to set a min version (for mac-notification-sys since that was broken) but i'd rather risk it if it means i don't get screamed at again for setting the min minor/patch versions too high 🙃 |
Understandable - I've seen both sides! I'm not pushing for it, as I know ultimately it'll be the core tauri team that deals with the fallout. Feel free to either close out this PR or merge the lockfile change if you're happy. Thanks as always Fabian (& Lucas)! |
i'll merge this as-is then and keep monitoring reports about 2431 - thanks :) |
Package Changes Through 45940f9There are 2 changes which include log with minor, log-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Upgrades
notify-rust
to a patched version as the previous allowed versions included one which resulted in a panic on MacOS when any notification was sent. See #2431Verified as working following these changes, it no longer just panics (which was crashing Tauri):

My first contribution to this repo, so let me know if there's something I've done wrong or missed, or feel free to tweak this