-
Notifications
You must be signed in to change notification settings - Fork 425
feat(updater): support bundle-specific targets #2624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(updater): support bundle-specific targets #2624
Conversation
…gins-workspace into feature/fallback_targets
…gins-workspace into feature/fallback_targets # Conflicts: # plugins/updater/tests/app-updater/tests/update.rs
…gins-workspace into feature/fallback_targets
…gins-workspace into feature/fallback_targets
…ature/fallback_targets
Package Changes Through abcee1fThere are 2 changes which include updater with minor, updater-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Windows and Linux tests are failing because they require tauri-cli with tauri-apps/tauri#13209 change. MacOS test is failing because of some compliation issue. I will have access to a mac next week so I will fix it. |
It looks like you ran |
Co-authored-by: Fabian-Lars <[email protected]>
Addressed the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on my part
Not all of them yet :) |
@FabianLars checked all the comments again. Some of them I would rather leave for another PR (better to finally merge this and keep working in a clean branch). I moved the bundle type to a pure function. The only unaddressed comment is the one about mixed up responsibilities but I don't know what specifically should be changed there. Any ideas? |
I think we can release this one next week |
I have reverted the tauri bumps to align with the main branch, and since we have already bumped the workspace tauri requirement to 2.8 in main branch, we can remove the separate bump in the updater plugin now |
after merging this, please wait with the release until we support the |
@FabianLars can please explain what needs to be done for the I will also take a look at latest.json generation. |
it's for the dynamic urls, yes and i'm pretty sure that it would require really just #2624 (comment) and #2624 (comment) edit: nevermind, with some of the changes since then those suggestions don't work as-is anymore but the gist is the same. |
Ok, I'm happy to do it. I can work on it this week. |
went ahead and opened #2960 sorry 😅 wanted to get to testing asap |
Here are the changes for updater to handle #2277
I'm using the patched __TAURI_BUNDLE_TYPE variable to download the proper installer with fallback as described in #2277.
I've added some additional test on both Linux and Windows. Not sure if something needs to be done on other platforms.