Skip to content

Conversation

asomethings
Copy link
Contributor

followup for: #2647 and #2636

Description

For maximum compatibility I think it should follow fetch spec

Though Chromium only handles 101, 204, 205, 304

And Firefox only handles 204, 205, 304

@asomethings asomethings requested a review from a team as a code owner April 22, 2025 05:21
Copy link
Contributor

Package Changes Through 23b327b

There are 7 changes which include single-instance with patch, fs with minor, fs-js with minor, http with patch, http-js with patch, opener with patch, opener-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.25 2.0.26
api-example-js 2.0.21 2.0.22
fs 2.2.1 2.3.0
fs-js 2.2.1 2.3.0
dialog 2.2.1 2.2.2
dialog-js 2.2.1 2.2.2
opener 2.2.6 2.2.7
opener-js 2.2.6 2.2.7
http 2.4.3 2.4.4
http-js 2.4.3 2.4.4
persisted-scope 2.2.1 2.2.2
single-instance 2.2.3 2.2.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

Ah didn't check chromium and just Firefox but iirc in Firefox you can't even construct Responses with 10X statuses so I didn't bother mentioning them in that pr (which was dumb)

@asomethings
Copy link
Contributor Author

@FabianLars To improve performance, should we consider using an if statement instead? Benchmark

@FabianLars
Copy link
Member

Hmm I don't think this difference matters much.

@amrbashir amrbashir merged commit 2448e71 into tauri-apps:v2 Apr 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants