Skip to content

Conversation

FabianLars
Copy link
Member

fixes #2752

I took a more conservative approach than i first wanted after reading Tony's comment. Really didn't want to touch the bundler or nsis utils at the moment and this whole cli arg stuff gives me a headache.
Maybe we can revise this whole logic when we refactor the code a bit (if that happens).

also i think we'll need to double check the msi escape method. looks like i missed args with spaces not starting with - ? Can't test it right now.

@FabianLars FabianLars requested a review from a team as a code owner June 11, 2025 13:14
Copy link
Contributor

github-actions bot commented Jun 11, 2025

Package Changes Through 86fc166

There are 8 changes which include updater with minor, updater-js with minor, autostart with minor, autostart-js with minor, log with minor, log-js with minor, opener with minor, opener-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.26 2.0.27
api-example-js 2.0.22 2.0.23
autostart 2.3.0 2.4.0
autostart-js 2.3.0 2.4.0
opener 2.2.7 2.3.0
opener-js 2.2.7 2.3.0
log 2.4.0 2.5.0
log-js 2.4.0 2.5.0
updater 2.7.1 2.8.0
updater-js 2.7.1 2.8.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars FabianLars merged commit 735d209 into v2 Jun 17, 2025
19 checks passed
@FabianLars FabianLars deleted the fix/updater-nsis-args branch June 17, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Updating an app launched with arguments that have a space in them does not relaunch the app after update
3 participants