-
Notifications
You must be signed in to change notification settings - Fork 425
fix(updater): Escape current_exe args for nsis installer #2761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package Changes Through 86fc166There are 8 changes which include updater with minor, updater-js with minor, autostart with minor, autostart-js with minor, log with minor, log-js with minor, opener with minor, opener-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
fixes #2752
I took a more conservative approach than i first wanted after reading Tony's comment. Really didn't want to touch the bundler or nsis utils at the moment and this whole cli arg stuff gives me a headache.
Maybe we can revise this whole logic when we refactor the code a bit (if that happens).
also i think we'll need to double check the msi escape method. looks like i missed args with spaces not starting with
-
? Can't test it right now.