Skip to content

Conversation

Innominus
Copy link

@Innominus Innominus commented Jun 25, 2025

Code formatter has changed the kt code structure for the edited file. If it's not following guidelines/code format standards I'm happy to remove the extra whitespace changes.

Essentially it seems when writing the actions for an action group, it wasn't writing them the same way it was reading them. So it would add the actions but without an ID/title/input so they would show up blank.

Before:
image
After:
image

This is also what the code might look like when using the new builder syntax for ActionType and Action:

    let action_type = ActionType::builder("action-buttons")
        .actions(vec![
            Action::builder("visible-id", "Visible").foreground(true).build(),
            Action::builder("notification-action-id", "Notification Action Titles")
                .foreground(true)
                .build(),
        ])
        .build();

can register them; fix Android incorrectly storing actions in an action
group
@Innominus Innominus requested a review from a team as a code owner June 25, 2025 07:59
Copy link
Contributor

github-actions bot commented Jun 25, 2025

Package Changes Through 19c7a8e

There are 4 changes which include nfc with patch, nfc-js with patch, store with minor, store-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
api-example 2.0.32 2.0.33
api-example-js 2.0.28 2.0.29
nfc 2.3.0 2.3.1
nfc-js 2.3.0 2.3.1
store 2.3.0 2.4.0
store-js 2.3.0 2.4.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member

ah merging v2 into this branch was dumb of me, i didn't see that your commit wasn't signed (please set that up for the future), i just made that harder so it'd be okay for me to skip it just this once :P

sorry for the long silence btw, i was waiting for the ci errors to be resolved and totally forgot about the PR in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants