-
Notifications
You must be signed in to change notification settings - Fork 425
feat(store): load override defaults #2857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): load override defaults #2857
Conversation
Package Changes Through 94cc9beThere are 4 changes which include nfc with patch, nfc-js with patch, store with minor, store-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
Done |
should it be ignoreDefaults and load_without_defaults maybe? override to me sounds like we're still loading the defaults first and then overriding those with the ondisk state. |
We can change the name on the other ones though |
the store plugin is giving me such a headache and i'm not even working on it 🫠 |
Reference: #2829
Reference: #2855
Reference: #2843 (comment)
Closes #2843
Add an new option
overrideDefaults
for creating/loading and reloading the store that overrides the store with the on-disk state, ignoring defaultsAlso added support for setting
defaults
from the JavaScript APIFor the
reload
function, we should change its behavior to resetting the store todefaults
first and then callingextend
to merge the values inload
in v3, and document this in v2 for now